qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] vmdk: Fix zero cluster allocation


From: Eric Blake
Subject: Re: [PATCH 2/6] vmdk: Fix zero cluster allocation
Date: Thu, 30 Apr 2020 09:14:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 4/30/20 8:30 AM, Kevin Wolf wrote:
m_data must be contain valid data even for zero clusters when no cluster

s/be //

was allocated in the image file. Without this, zero writes segfault with
images that have zeroed_grain=on.

For zero writes, we don't want to allocate a cluster in the image file
even in compressed files.

Fixes: 524089bce43fd1cd3daaca979872451efa2cf7c6

Nearly 4 years ago, and claims to fix a different regression. Wow, we aren't doing too well with vmdk.

Signed-off-by: Kevin Wolf <address@hidden>
---
  block/vmdk.c | 12 +++++++-----
  1 file changed, 7 insertions(+), 5 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]