[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/15] acpi: move aml builder code for rtc device
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v3 07/15] acpi: move aml builder code for rtc device |
Date: |
Thu, 30 Apr 2020 14:13:09 +0200 |
On Wed, 29 Apr 2020 15:59:55 +0200
Gerd Hoffmann <address@hidden> wrote:
> Also use a single io range instead of two,
> following what real hardware does.
I'd make a separate patch for this comment.
Also qemu maps only the first range (0x70) if I'm not mistaken,
so we perhaps should drop the second (0x72) instead of merging it into the first
[...]
> -static Aml *build_rtc_device_aml(void)
> -{
> - Aml *dev;
> - Aml *crs;
> -
> - dev = aml_device("RTC");
> - aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
> - crs = aml_resource_template();
> - aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02));
> - aml_append(crs, aml_irq_no_flags(8));
> - aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06));
[...]
> +static void rtc_build_aml(ISADevice *isadev, Aml *scope)
> +{
> + Aml *dev;
> + Aml *crs;
> +
> + crs = aml_resource_template();
> + aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
> + 0x10, 0x08));
[...]
- [PATCH v3 04/15] acpi: drop pointless _STA method, (continued)
- [PATCH v3 04/15] acpi: drop pointless _STA method, Gerd Hoffmann, 2020/04/29
- [PATCH v3 09/15] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 03/15] qtest: allow DSDT acpi table changes, Gerd Hoffmann, 2020/04/29
- [PATCH v3 11/15] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 05/15] acpi: add ISADeviceClass->build_aml(), Gerd Hoffmann, 2020/04/29
- [PATCH v3 15/15] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/04/29
- [PATCH v3 07/15] acpi: move aml builder code for rtc device, Gerd Hoffmann, 2020/04/29
- Re: [PATCH v3 07/15] acpi: move aml builder code for rtc device,
Igor Mammedov <=
- [PATCH v3 12/15] acpi: move aml builder code for floppy device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 13/15] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/04/29
- [PATCH v3 14/15] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/04/29
- [PATCH v3 06/15] rtc: add RTC_ISA_BASE, Gerd Hoffmann, 2020/04/29