[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] block: Add blk_make_empty()
From: |
Max Reitz |
Subject: |
Re: [PATCH 3/4] block: Add blk_make_empty() |
Date: |
Wed, 29 Apr 2020 09:39:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 28.04.20 16:47, Kevin Wolf wrote:
> Am 28.04.2020 um 15:26 hat Max Reitz geschrieben:
>> Two callers of BlockDriver.bdrv_make_empty() remain that should not call
>> this method directly. Both do not have access to a BdrvChild, but they
>> can use a BlockBackend, so we add this function that lets them use it.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> include/sysemu/block-backend.h | 2 ++
>> block/block-backend.c | 5 +++++
>> 2 files changed, 7 insertions(+)
>>
>> diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
>> index d37c1244dd..14338b76dc 100644
>> --- a/include/sysemu/block-backend.h
>> +++ b/include/sysemu/block-backend.h
>> @@ -266,4 +266,6 @@ int coroutine_fn blk_co_copy_range(BlockBackend *blk_in,
>> int64_t off_in,
>>
>> const BdrvChild *blk_root(BlockBackend *blk);
>>
>> +int blk_make_empty(BlockBackend *blk, Error **errp);
>> +
>> #endif
>> diff --git a/block/block-backend.c b/block/block-backend.c
>> index 3592066b42..5d36efd32f 100644
>> --- a/block/block-backend.c
>> +++ b/block/block-backend.c
>> @@ -2402,3 +2402,8 @@ const BdrvChild *blk_root(BlockBackend *blk)
>> {
>> return blk->root;
>> }
>> +
>> +int blk_make_empty(BlockBackend *blk, Error **errp)
>> +{
>> + return bdrv_make_empty(blk->root, errp);
>> +}
>
> Should we check that blk->root != NULL? Most other functions do that
> through blk_is_available().
Why not.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 1/4] block: Add bdrv_make_empty(), (continued)
- [PATCH 2/4] block: Use bdrv_make_empty() where possible, Max Reitz, 2020/04/28
- [PATCH 3/4] block: Add blk_make_empty(), Max Reitz, 2020/04/28
- [PATCH 4/4] block: Use blk_make_empty() after commits, Max Reitz, 2020/04/28
- Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, no-reply, 2020/04/28
- Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, no-reply, 2020/04/28
- Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly, Eric Blake, 2020/04/28