|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v7 09/10] iotests: Test committing to short backing file |
Date: | Fri, 24 Apr 2020 17:49:26 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
24.04.2020 15:54, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
[..]
+ + # After this, 0 to base_size should be allocated/zeroed.
Actually, top_size_old to base_size, yes? (sorry, nitpicking, missed on previous review).
+ # + # In theory, leaving base_size to top_size_new unallocated would be + # correct, but in practice, if we zero out anything, we zero out + # everything up to top_size_new. + iotests.qemu_img_log('resize', '-f', iotests.imgfmt, + '--preallocation', prealloc, top, top_size_new) + iotests.qemu_io_log('-c', 'read -P 0 %s 64k' % off, top) + iotests.qemu_io_log('-c', 'map', top) + iotests.qemu_img_log('map', '--output=json', top)
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |