[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 13/16] nvme: factor out namespace setup
|
From: |
Klaus Birkelund Jensen |
|
Subject: |
Re: [PATCH v2 13/16] nvme: factor out namespace setup |
|
Date: |
Thu, 16 Apr 2020 08:03:30 +0200 |
On Apr 15 15:26, Philippe Mathieu-Daudé wrote:
> On 4/15/20 3:20 PM, Klaus Birkelund Jensen wrote:
> >
> > I'll get the v1.3 series ready next.
> >
>
> Cool. What really matters (to me) is seeing tests. If we can merge tests
> (without multiple namespaces) before the rest of your series, even better.
> Tests give reviewers/maintainers confidence that code isn't breaking ;)
>
The patches that I contribute have been pretty extensively tested by
various means in a "host setting" (e.g. blktests and some internal
tools), which really exercise the device by doing heavy I/O, testing for
compliance and also just being mean to it (e.g. tripping bus mastering
while doing I/O).
Don't misunderstand me as trying to weasel my way out of writing tests,
but I just want to understand the scope of the tests that you are
looking for? I believe (hope!) that you are not asking me to implement a
user-space NVMe driver in the test, so I assume the tests should varify
more low level details?
- [PATCH v2 05/16] nvme: use constants in identify, (continued)
- [PATCH v2 05/16] nvme: use constants in identify, Klaus Jensen, 2020/04/15
- [PATCH v2 07/16] nvme: add max_ioqpairs device parameter, Klaus Jensen, 2020/04/15
- [PATCH v2 03/16] nvme: remove superfluous breaks, Klaus Jensen, 2020/04/15
- [PATCH v2 02/16] nvme: rename trace events to pci_nvme, Klaus Jensen, 2020/04/15
- [PATCH v2 13/16] nvme: factor out namespace setup, Klaus Jensen, 2020/04/15
Re: [PATCH v2 13/16] nvme: factor out namespace setup, Maxim Levitsky, 2020/04/21
[PATCH v2 11/16] nvme: factor out block backend setup, Klaus Jensen, 2020/04/15
[PATCH v2 16/16] nvme: factor out controller identify setup, Klaus Jensen, 2020/04/15
[PATCH v2 12/16] nvme: add namespace helpers, Klaus Jensen, 2020/04/15