qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 02/48] nvme: remove superfluous breaks


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v7 02/48] nvme: remove superfluous breaks
Date: Wed, 15 Apr 2020 08:57:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/15/20 7:50 AM, Klaus Jensen wrote:
From: Klaus Jensen <address@hidden>

These break statements was left over when commit 3036a626e9ef ("nvme:
add Get/Set Feature Timestamp support") was merged.

Signed-off-by: Klaus Jensen <address@hidden>
Acked-by: Keith Busch <address@hidden>
Reviewed-by: Maxim Levitsky <address@hidden>
---
  hw/block/nvme.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 01e18fb9eb1f..da0e8af42823 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -788,7 +788,6 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeCmd *cmd, 
NvmeRequest *req)
          break;
      case NVME_TIMESTAMP:
          return nvme_get_feature_timestamp(n, cmd);
-        break;
      default:
          trace_nvme_dev_err_invalid_getfeat(dw10);
          return NVME_INVALID_FIELD | NVME_DNR;
@@ -832,11 +831,8 @@ static uint16_t nvme_set_feature(NvmeCtrl *n, NvmeCmd 
*cmd, NvmeRequest *req)
          req->cqe.result =
              cpu_to_le32((n->num_queues - 2) | ((n->num_queues - 2) << 16));
          break;
-
      case NVME_TIMESTAMP:
          return nvme_set_feature_timestamp(n, cmd);
-        break;
-
      default:
          trace_nvme_dev_err_invalid_setfeat(dw10);
          return NVME_INVALID_FIELD | NVME_DNR;


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]