[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 14/30] qcow2: Add cluster type parameter to qcow2_get_host
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v4 14/30] qcow2: Add cluster type parameter to qcow2_get_host_offset() |
|
Date: |
Tue, 14 Apr 2020 14:38:43 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 14 Apr 2020 02:30:30 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
>> - ret = qcow2_get_host_offset(bs, offset, &nr, &off);
>> - if (ret != QCOW2_CLUSTER_UNALLOCATED &&
>> - ret != QCOW2_CLUSTER_ZERO_PLAIN &&
>> - ret != QCOW2_CLUSTER_ZERO_ALLOC) {
>> + ret = qcow2_get_host_offset(bs, offset, &nr, &off, &type);
>
> pre-patch, but probably better to return original errno on
> qcow2_get_host_offset failure, instead of masking it.
Yeah, I think you're right. I can take care of that on a separate patch.
Berto