Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper

From:	Eric Blake
Subject:	Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper
Date:	Thu, 9 Apr 2020 13:15:07 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 4/9/20 10:30 AM, Markus Armbruster wrote:

Signed-off-by: Markus Armbruster <address@hidden>
---
  qemu-img.c | 59 +++++++++++++++++++++---------------------------------
  1 file changed, 23 insertions(+), 36 deletions(-)

Nice.
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH for-5.1 8/8] qemu-option: Move is_valid_option_list() to qemu-img.c and rewrite, (continued)
- [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper, Markus Armbruster, 2020/04/09
  - Re: [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper, Eric Blake, 2020/04/09
    - Re: [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper, Markus Armbruster, 2020/04/14
    - Re: [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper, Kevin Wolf, 2020/04/14
    - Re: [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper, Markus Armbruster, 2020/04/15
  - Re: [PATCH for-5.1 2/8] qemu-options: Factor out get_opt_name_value() helper, Kevin Wolf, 2020/04/14
- [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper, Markus Armbruster, 2020/04/09
  - Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper, Eric Blake <=
  - Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper, Kevin Wolf, 2020/04/14
- [PATCH for-5.1 5/8] qemu-option: Fix has_help_option()'s sloppy parsing, Markus Armbruster, 2020/04/09
  - Re: [PATCH for-5.1 5/8] qemu-option: Fix has_help_option()'s sloppy parsing, Eric Blake, 2020/04/09
    - Re: [PATCH for-5.1 5/8] qemu-option: Fix has_help_option()'s sloppy parsing, Markus Armbruster, 2020/04/14
    - Re: [PATCH for-5.1 5/8] qemu-option: Fix has_help_option()'s sloppy parsing, Kevin Wolf, 2020/04/14
    - Re: [PATCH for-5.1 5/8] qemu-option: Fix has_help_option()'s sloppy parsing, Markus Armbruster, 2020/04/15
- [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt(), Markus Armbruster, 2020/04/09
  - Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt(), Eric Blake, 2020/04/09
    - Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt(), Markus Armbruster, 2020/04/14
    - Re: [PATCH for-5.1 1/8] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt(), Kevin Wolf, 2020/04/14

Prev by Date: Re: [PATCH for-5.1 6/8] test-qemu-opts: Simplify test_has_help_option() after bug fix
Next by Date: Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters
Previous by thread: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper
Next by thread: Re: [PATCH for-5.1 7/8] qemu-img: Factor out accumulate_options() helper
Index(es):
- Date
- Thread