[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 00/14] iotests: use python logging
From: |
John Snow |
Subject: |
Re: [PATCH v9 00/14] iotests: use python logging |
Date: |
Mon, 30 Mar 2020 15:41:30 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 3/30/20 9:00 AM, Max Reitz wrote:
> On 25.03.20 00:20, John Snow wrote:
>> This series uses python logging to enable output conditionally on
>> iotests.log(). We unify an initialization call (which also enables
>> debugging output for those tests with -d) and then make the switch
>> inside of iotests.
>>
>> It will help alleviate the need to create logged/unlogged versions
>> of all the various helpers we have made.
>>
>> Also, I got lost and accidentally delinted iotests while I was here.
>> Sorry about that. By version 9, it's now the overwhelming focus of
>> this series. No good deed, etc.
>
> Generally, test patches are fair game for the freeze period. However,
> this series is quite extensive, so I might prefer block-next here.
> OTOH, if I do take it to block-next, patch 11 might grow stale.
>
> Do you have a strong opinion either way?
>
> Max
>
Not really, no.
Might be nice to see it tossed into the RC while everyone is doing
testing to see if it causes problems. On the other hand, it probably
WILL cause problems with various untested version combinations and so forth.
Either or.
--js
- [PATCH v9 12/14] iotest 258: use script_main, (continued)
- [PATCH v9 13/14] iotests: Mark verify functions as private, John Snow, 2020/03/24
- [PATCH v9 11/14] iotests: add script_initialize, John Snow, 2020/03/24
- [PATCH v9 14/14] iotests: use python logging for iotests.log(), John Snow, 2020/03/24
- Re: [PATCH v9 00/14] iotests: use python logging, Max Reitz, 2020/03/30
- Re: [PATCH v9 00/14] iotests: use python logging,
John Snow <=
- Re: [PATCH v9 00/14] iotests: use python logging, John Snow, 2020/03/30