[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create
|
From: |
Maxim Levitsky |
|
Subject: |
Re: [PATCH 1/2] block: pass BlockDriver reference to the .bdrv_co_create |
|
Date: |
Thu, 26 Mar 2020 15:22:01 +0200 |
On Thu, 2020-03-26 at 08:18 -0500, Eric Blake wrote:
> On 3/25/20 8:12 PM, Maxim Levitsky wrote:
> > This will allow to reuse a single generic .bdrv_co_create
>
> "allow to ${verb}" is not idiomatic, better is "allow ${subject} to
> ${verb}" or "allow ${verb}ing". In this case, I'd go with:
>
> This will allow the reuse of a single...
I agree! This commit will probably go as is but next time I'll keep it in mind!
Best regards,
Maxim Levitsky
>
> > implementation for several drivers.
> > No functional changes.
> >
> > Signed-off-by: Maxim Levitsky <address@hidden>
> > ---
Re: [PATCH 0/2] Fix the generic image creation code, Denis V. Lunev, 2020/03/26
Re: [PATCH 0/2] Fix the generic image creation code, Max Reitz, 2020/03/26