[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] lockable: replaced locks with lock guard macros where
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate |
|
Date: |
Fri, 20 Mar 2020 13:55:31 +0000 |
|
User-agent: |
Mutt/1.13.3 (2020-01-12) |
* Paolo Bonzini (address@hidden) wrote:
> On 20/03/20 13:56, Dr. David Alan Gilbert wrote:
> >> According to https://wiki.qemu.org/ToDo/LockGuards cases that are trivial
> >> (no
> >> conditional logic) shouldn't be replaced.
> > OK
>
> I don't think that has to be either-or. Trivial lock/unlock sequences
> are not the first ones that should be converted, but there's an
> advantage in having a single patch that converts all possible uses of a
> lock. Trivial sequences certainly do not belong in a bigger patch like
> this, as they would make the patch even bigger.
>
> > So for what you've already got there,
> >
> > For migration:
> > Acked-by: Dr. David Alan Gilbert <address@hidden>
> >
>
> Can you just extract that and queue it yourself (for 5.1 probably)?
I can, although it would be easier if Daniel did that; there's no rush
given it's for 5.1
> Paolo
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK