[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] Use &error_abort instead of separate assert()
|
From: |
Alexander Bulekov |
|
Subject: |
Re: [PATCH 1/3] Use &error_abort instead of separate assert() |
|
Date: |
Fri, 13 Mar 2020 13:37:45 -0400 |
|
User-agent: |
NeoMutt/20180716 |
On 200313 1805, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> index 1a99277d60..aa9eee6ebf 100644
> --- a/tests/qtest/fuzz/qos_fuzz.c
> +++ b/tests/qtest/fuzz/qos_fuzz.c
> @@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void)
> QList *lst;
> Error *err = NULL;
Can this err declaration be removed? Don't think it's used anywhere
else.
>
> - qmp_marshal_query_machines(NULL, &response, &err);
> - assert(!err);
> + qmp_marshal_query_machines(NULL, &response, &error_abort);
> lst = qobject_to(QList, response);
> apply_to_qlist(lst, true);
>
> @@ -70,8 +69,7 @@ static void qos_set_machines_devices_available(void)
> qdict_put_bool(args, "abstract", true);
> qdict_put_obj(req, "arguments", (QObject *) args);
>
> - qmp_marshal_qom_list_types(args, &response, &err);
> - assert(!err);
> + qmp_marshal_qom_list_types(args, &response, &error_abort);
> lst = qobject_to(QList, response);
> apply_to_qlist(lst, false);
> qobject_unref(response);
> --
> 2.21.1
>
Thanks!
Acked-by: Alexander Bulekov <address@hidden>
[PATCH 2/3] hw/misc/ivshmem: Use one Error * variable instead of two, Markus Armbruster, 2020/03/13
Re: [PATCH 0/3] Minor error handling cleanups, Peter Maydell, 2020/03/13
[PATCH v10 4/3] hw/sd/ssi-sd: fix error handling in ssi_sd_realize, Vladimir Sementsov-Ogievskiy, 2020/03/17