Re: [PATCH v2 00/14] LUKS: encryption slot management using amend interface

[Eric Blake]

On 3/8/20 10:18 AM, Maxim Levitsky wrote:
> Hi!
> Here is the updated series of my patches, incorporating all the feedback I 
> received.

> Patches are strictly divided by topic to 3 groups, and each group depends on 
> former groups.
>
> * Patches 1,2 implement qcrypto generic amend interface, including definition
>    of structs used in crypto.json and implement this in luks crypto driver
>    Nothing is exposed to the user at this stage
>
> * Patches 3-9 use the code from patches 1,2 to implement qemu-img amend based 
> encryption slot management
>    for luks and for qcow2, and add a bunch of iotests to cover that.
>
> * Patches 10-13 add x-blockdev-amend (I'll drop the -x prefix if you like), and 
> wire it
>    to luks and qcow2 driver to implement qmp based encryption slot management 
> also using
>    the code from patches 1,2, and also add a bunch of iotests to cover this.

>   tests/qemu-iotests/284.out       |   6 +-
>   tests/qemu-iotests/300           | 207 ++++++++++++++++

Any reason why you skipped straight to test 300, rather than using an 
available slot like 290?  (Admittedly, our process for reserving slots 
is not very high-tech: manually scan the list for what other patches out 
there have claimed a slot, and be prepared to renumber when rebasing)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org