Re: [PATCH v4 00/10] Further bitmaps improvements

[Max Reitz]

On 11.03.20 07:17, Vladimir Sementsov-Ogievskiy wrote:
> 10.03.2020 20:17, Max Reitz wrote:
>> On 06.03.20 08:45, Vladimir Sementsov-Ogievskiy wrote:
>>> 26.02.2020 16:13, Max Reitz wrote:
>>>> On 05.02.20 12:20, Vladimir Sementsov-Ogievskiy wrote:
>>>>> Hi!
>>>>>
>>>>> The main feature here is improvement of _next_dirty_area API, which
>>>>> I'm
>>>>> going to use then for backup / block-copy.
>>>>>
>>>>> Somehow, I thought that it was merged, but seems I even forgot to send
>>>>> v4.
>>>>
>>>> The changes from v3 look good to me, but I’d prefer a review from Eric
>>>> on patch 8.
>>>>
>>>
>>> Hi!
>>>
>>> Could you take it now, or do you prefer me to resend?
>>
>> I understand that you agreed to drop the comment above
>> bd_extent_array_convert_to_be(), then do the
>> “s/further call/so further calls/” replacement, and finally replace the
>> whole four lines Eric has quoted by “(this ensures that after a failure,
>> no further extents can accidentally change the bounds of the last extent
>> in the array)”?
>>
> 
> Yes, all true.

Hm, I could take it then, but on second thought, John is the maintainer
for 8/10 patches, and Eric is for the other two...  So I’m not sure
whether I’m even the right person to do so.

Max

signature.asc
Description: OpenPGP digital signature