[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/9] block/block-copy: rename start to offset in interface
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 7/9] block/block-copy: rename start to offset in interfaces |
Date: |
Tue, 10 Mar 2020 15:50:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 06.03.20 08:38, Vladimir Sementsov-Ogievskiy wrote:
> offset/bytes pair is more usual naming in block layer, let's use it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Andrey Shinkevich <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> include/block/block-copy.h | 4 +-
> block/block-copy.c | 84 +++++++++++++++++++-------------------
> 2 files changed, 44 insertions(+), 44 deletions(-)
[...]
> diff --git a/block/block-copy.c b/block/block-copy.c
> index 4c947e548b..2b29131653 100644
> --- a/block/block-copy.c
> +++ b/block/block-copy.c
> @@ -25,13 +25,13 @@
> #define BLOCK_COPY_MAX_MEM (128 * MiB)
>
> static BlockCopyInFlightReq *find_conflicting_inflight_req(BlockCopyState *s,
> - int64_t start,
> - int64_t bytes)
> + int64_t offset,
> + int64_t bytes)
The alignment’s off now.
Max
signature.asc
Description: OpenPGP digital signature
[PATCH v3 6/9] block/block-copy: refactor interfaces to use bytes instead of end, Vladimir Sementsov-Ogievskiy, 2020/03/06
[PATCH v3 2/9] block/block-copy: fix progress calculation, Vladimir Sementsov-Ogievskiy, 2020/03/06
[PATCH v3 9/9] block/block-copy: hide structure definitions, Vladimir Sementsov-Ogievskiy, 2020/03/06