[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH] qcow2: remove QCowL2Meta parameter from handle_copied |
|
Date: |
Tue, 10 Mar 2020 12:19:34 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 10 Mar 2020 03:04:47 AM CET, John Snow wrote:
>> static int handle_copied(BlockDriverState *bs, uint64_t guest_offset,
>> - uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
>> + uint64_t *host_offset, uint64_t *bytes)
>> {
>> BDRVQcow2State *s = bs->opaque;
>> int l2_index;
>> @@ -1567,7 +1567,7 @@ again:
>> /*
>> * 2. Count contiguous COPIED clusters.
>> */
>> - ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
>> + ret = handle_copied(bs, start, &cluster_offset, &cur_bytes);
>> if (ret < 0) {
>> return ret;
>> } else if (ret) {
>>
>
> Seems OK to me -- it is definitely unused.
> (Is _that_ a problem? For qcow2 maintainers to know.)
It is unused now, but I'm using it in my subcluster allocation patches:
https://lists.gnu.org/archive/html/qemu-block/2019-12/msg00588.html
(I expect to send v4 soon, probably this week)
Berto