Re: [PATCH v3 2/4] scripts/simplebench: add qemu/bench_block_job.py

[Aleksandar Markovic]

On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy
<address@hidden> wrote:
>
> Add block-job benchmarking helper functions.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---

Reviewed-by: Aleksandar Markovic <address@hidden>

>  scripts/simplebench/bench_block_job.py | 119 +++++++++++++++++++++++++
>  1 file changed, 119 insertions(+)
>  create mode 100755 scripts/simplebench/bench_block_job.py
>
> diff --git a/scripts/simplebench/bench_block_job.py 
> b/scripts/simplebench/bench_block_job.py
> new file mode 100755
> index 0000000000..9808d696cf
> --- /dev/null
> +++ b/scripts/simplebench/bench_block_job.py
> @@ -0,0 +1,119 @@
> +#!/usr/bin/env python
> +#
> +# Benchmark block jobs
> +#
> +# Copyright (c) 2019 Virtuozzo International GmbH.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +
> +import sys
> +import os
> +import socket
> +import json
> +
> +sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 
> 'python'))
> +from qemu.machine import QEMUMachine
> +from qemu.qmp import QMPConnectError
> +
> +
> +def bench_block_job(cmd, cmd_args, qemu_args):
> +    """Benchmark block-job
> +
> +    cmd       -- qmp command to run block-job (like blockdev-backup)
> +    cmd_args  -- dict of qmp command arguments
> +    qemu_args -- list of Qemu command line arguments, including path to Qemu
> +                 binary
> +
> +    Returns {'seconds': int} on success and {'error': str} on failure, dict 
> may
> +    contain addional 'vm-log' field. Return value is compatible with
> +    simplebench lib.
> +    """
> +
> +    vm = QEMUMachine(qemu_args[0], args=qemu_args[1:])
> +
> +    try:
> +        vm.launch()
> +    except OSError as e:
> +        return {'error': 'popen failed: ' + str(e)}
> +    except (QMPConnectError, socket.timeout):
> +        return {'error': 'qemu failed: ' + str(vm.get_log())}
> +
> +    try:
> +        res = vm.qmp(cmd, **cmd_args)
> +        if res != {'return': {}}:
> +            vm.shutdown()
> +            return {'error': '"{}" command failed: {}'.format(cmd, str(res))}
> +
> +        e = vm.event_wait('JOB_STATUS_CHANGE')
> +        assert e['data']['status'] == 'created'
> +        start_ms = e['timestamp']['seconds'] * 1000000 + \
> +            e['timestamp']['microseconds']
> +
> +        e = vm.events_wait((('BLOCK_JOB_READY', None),
> +                            ('BLOCK_JOB_COMPLETED', None),
> +                            ('BLOCK_JOB_FAILED', None)), timeout=True)
> +        if e['event'] not in ('BLOCK_JOB_READY', 'BLOCK_JOB_COMPLETED'):
> +            vm.shutdown()
> +            return {'error': 'block-job failed: ' + str(e),
> +                    'vm-log': vm.get_log()}
> +        end_ms = e['timestamp']['seconds'] * 1000000 + \
> +            e['timestamp']['microseconds']
> +    finally:
> +        vm.shutdown()
> +
> +    return {'seconds': (end_ms - start_ms) / 1000000.0}
> +
> +
> +# Bench backup or mirror
> +def bench_block_copy(qemu_binary, cmd, source, target):
> +    """Helper to run bench_block_job() for mirror or backup"""
> +    assert cmd in ('blockdev-backup', 'blockdev-mirror')
> +
> +    source['node-name'] = 'source'
> +    target['node-name'] = 'target'
> +
> +    return bench_block_job(cmd,
> +                           {'job-id': 'job0', 'device': 'source',
> +                            'target': 'target', 'sync': 'full'},
> +                           [qemu_binary,
> +                            '-blockdev', json.dumps(source),
> +                            '-blockdev', json.dumps(target)])
> +
> +
> +def drv_file(filename):
> +    return {'driver': 'file', 'filename': filename,
> +            'cache': {'direct': True}, 'aio': 'native'}
> +
> +
> +def drv_nbd(host, port):
> +    return {'driver': 'nbd',
> +            'server': {'type': 'inet', 'host': host, 'port': port}}
> +
> +
> +if __name__ == '__main__':
> +    import sys
> +
> +    if len(sys.argv) < 4:
> +        print('USAGE: {} <qmp block-job command name> '
> +              '<json string of arguments for the command> '
> +              '<qemu binary path and arguments>'.format(sys.argv[0]))
> +        exit(1)
> +
> +    res = bench_block_job(sys.argv[1], json.loads(sys.argv[2]), sys.argv[3:])
> +    if 'seconds' in res:
> +        print('{:.2f}'.format(res['seconds']))
> +    else:
> +        print(res)
> --
> 2.21.0
>
>