[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] fix two small memleaks
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 0/2] fix two small memleaks |
Date: |
Thu, 27 Feb 2020 16:24:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 27.02.20 02:29, Pan Nengyuan wrote:
> This series fix two small memleaks.
> 1. 'crypto_opts' forgot to free in qcow2_close(), do this cleanup in
> qcow2_close();
> 2. Do free filename/format in collect_image_check() when we re-allocate it.
>
> v2->v1:
> - Instead of freeing part of fields in collect_image_check(), do discard the
> old check object and allocate a new one in the caller to make more
> sense.(suggested by Max Reitz)
>
> Pan Nengyuan (2):
> block/qcow2: do free crypto_opts in qcow2_close()
> qemu-img: free memory before re-assign
>
> block/qcow2.c | 1 +
> qemu-img.c | 2 ++
> 2 files changed, 3 insertions(+)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature