[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block: Fix leak in bdrv_create_file_fallback()
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH] block: Fix leak in bdrv_create_file_fallback() |
|
Date: |
Wed, 26 Feb 2020 14:56:12 +0100 |
|
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 25.02.2020 um 16:56 hat Max Reitz geschrieben:
> @options is leaked by the first two return statements in this function.
>
> Note that blk_new_open() takes the reference to @options even on
> failure, so all we need to do to fix the leak is to move the QDict
> allocation down to where we actually need it.
>
> Reported-by: Coverity (CID 1419884)
> Fixes: fd17146cd93d1704cd96d7c2757b325fc7aac6fd
> ("block: Generic file creation fallback")
> Signed-off-by: Max Reitz <address@hidden>
Thanks, applied to the block branch.
Kevin