[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/10] block/dirty-bitmap: switch _next_dirty_area and _ne
From: |
Max Reitz |
Subject: |
Re: [PATCH v4 05/10] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t |
Date: |
Wed, 26 Feb 2020 13:39:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 05.02.20 12:20, Vladimir Sementsov-Ogievskiy wrote:
> We are going to introduce bdrv_dirty_bitmap_next_dirty so that same
> variable may be used to store its return value and to be its parameter,
> so it would int64_t.
>
> Similarly, we are going to refactor hbitmap_next_dirty_area to use
> hbitmap_next_dirty together with hbitmap_next_zero, therefore we want
> hbitmap_next_zero parameter type to be int64_t too.
>
> So, for convenience update all parameters of *_next_zero and
> *_next_dirty_area to be int64_t.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> include/block/dirty-bitmap.h | 6 +++---
> include/qemu/hbitmap.h | 7 +++----
> block/dirty-bitmap.c | 6 +++---
> nbd/server.c | 2 +-
> tests/test-hbitmap.c | 36 ++++++++++++++++++------------------
> util/hbitmap.c | 13 ++++++++-----
> 6 files changed, 36 insertions(+), 34 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [PATCH v4 10/10] block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty, (continued)
- [PATCH v4 10/10] block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 01/10] hbitmap: assert that we don't create bitmap larger than INT64_MAX, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 08/10] nbd/server: introduce NBDExtentArray, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 03/10] hbitmap: unpublish hbitmap_iter_skip_words, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 04/10] hbitmap: drop meta bitmaps as they are unused, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 05/10] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t, Vladimir Sementsov-Ogievskiy, 2020/02/05
- Re: [PATCH v4 05/10] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t,
Max Reitz <=
- [PATCH v4 07/10] block/dirty-bitmap: improve _next_dirty_area API, Vladimir Sementsov-Ogievskiy, 2020/02/05
- [PATCH v4 06/10] block/dirty-bitmap: add _next_dirty API, Vladimir Sementsov-Ogievskiy, 2020/02/05
- Re: [PATCH v4 00/10] Further bitmaps improvements, Vladimir Sementsov-Ogievskiy, 2020/02/26
- Re: [PATCH v4 00/10] Further bitmaps improvements, Max Reitz, 2020/02/26