[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll |
|
Date: |
Fri, 21 Feb 2020 14:44:34 +0000 |
On Fri, Feb 21, 2020 at 02:06:26PM +0100, Paolo Bonzini wrote:
> On 21/02/20 13:59, Stefan Hajnoczi wrote:
> > 1. It doesn't crash if the node is currently not on a list.
> > 2. It clears the node's linked list pointers so that future linked
> > list operations (like QLIST_SAFE_REMOVE()) aren't accidentally
> > performed on stale pointers.
> >
> > The node has a long lifespan and will be inserted into ready_lists
> > multiple times. We need to safely remove it from ready_list to protect
> > against a corruption the next time the node is inserted into a
> > ready_list again:
>
> Ah, so the one I singled out is for (2) (we know the node is currently
> on a list), while the one below is for (1). Would it make sense to move
> (2) to Q*_REMOVE_*? We can do it separately after this pull request.
Extending all Q*_REMOVE*() macros to clear the linked list pointers is
nice. I'll send a follow-up patch.
Stefan
signature.asc
Description: PGP signature
- Re: [PATCH 1/5] aio-posix: fix use after leaving scope in aio_poll(), (continued)
- [PATCH 2/5] aio-posix: don't pass ns timeout to epoll_wait(), Stefan Hajnoczi, 2020/02/14
- [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE(), Stefan Hajnoczi, 2020/02/14
- [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/14
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Sergio Lopez, 2020/02/19
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/19
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll,
Stefan Hajnoczi <=
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
[PATCH 4/5] aio-posix: make AioHandler deletion O(1), Stefan Hajnoczi, 2020/02/14
Re: [PATCH 0/5] aio-posix: towards an O(1) event loop, Stefan Hajnoczi, 2020/02/21