Re: [PATCH v2 12/22] qemu-iotests/199: fix style

[Andrey Shinkevich]

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote:
> Mostly, satisfy pep8 complains.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>   tests/qemu-iotests/199 | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/199
> index 40774eed74..de9ba8d94c 100755
> --- a/tests/qemu-iotests/199
> +++ b/tests/qemu-iotests/199
> @@ -28,8 +28,8 @@ disk_b = os.path.join(iotests.test_dir, 'disk_b')
>   size = '256G'
>   fifo = os.path.join(iotests.test_dir, 'mig_fifo')
>   
> -class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>   
> +class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>       def tearDown(self):
>           self.vm_a.shutdown()
>           self.vm_b.shutdown()
> @@ -54,7 +54,7 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>   
>           result = self.vm_a.qmp('block-dirty-bitmap-add', node='drive0',
>                                  name='bitmap', granularity=granularity)
> -        self.assert_qmp(result, 'return', {});
> +        self.assert_qmp(result, 'return', {})
>   
>           s = 0
>           while s < write_size:
> @@ -71,7 +71,7 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>   
>           result = self.vm_a.qmp('block-dirty-bitmap-clear', node='drive0',
>                                  name='bitmap')
> -        self.assert_qmp(result, 'return', {});
> +        self.assert_qmp(result, 'return', {})
>           s = 0
>           while s < write_size:
>               self.vm_a.hmp_qemu_io('drive0', 'write %d %d' % (s, chunk))
> @@ -104,15 +104,16 @@ class 
> TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>               self.vm_b.hmp_qemu_io('drive0', 'write %d %d' % (s, chunk))
>               s += 0x10000
>   
> -        result = self.vm_b.qmp('query-block');
> +        result = self.vm_b.qmp('query-block')
>           while len(result['return'][0]['dirty-bitmaps']) > 1:
>               time.sleep(2)
> -            result = self.vm_b.qmp('query-block');
> +            result = self.vm_b.qmp('query-block')
>   
>           result = self.vm_b.qmp('x-debug-block-dirty-bitmap-sha256',
>                                  node='drive0', name='bitmap')
>   
> -        self.assert_qmp(result, 'return/sha256', sha256);
> +        self.assert_qmp(result, 'return/sha256', sha256)
> +
>   
>   if __name__ == '__main__':
>       iotests.main(supported_fmts=['qcow2'], supported_cache_modes=['none'],

Reviewed-by: Andrey Shinkevich <address@hidden>
--
With the best regards,
Andrey Shinkevich