Re: [PATCH v4 00/19] block: Fix check_to_replace_node()

[Kevin Wolf]

Am 18.02.2020 um 11:34 hat Max Reitz geschrieben:
> Branch: https://github.com/XanClic/qemu.git fix-can-replace-v4
> Branch: https://git.xanclic.moe/XanClic/qemu.git fix-can-replace-v4
> 
> v1: https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01027.html
> v2: https://lists.nongnu.org/archive/html/qemu-block/2019-11/msg00370.html
> v3: https://lists.nongnu.org/archive/html/qemu-block/2020-01/msg00922.html
> 
> 
> Hi,
> 
> For what this series does, see the cover letter of v1 (linked above).
> 
> 
> Changes in v4 compared to v3:
> - Following the discussion with Kevin, I changed Quorum’s
>   .bdrv_recurse_can_replace() implementation from unsharing the
>   CONSISTENT_READ permission and taking the WRITE permission to just
>   checking whether there are any other parents
>   - This made the old patches 8 and 9 unnecessary, so they’ve been
>     dropped
>   - And of course it requires some changes to patch 10 (now 8)
>   - (Patch 10 (was: 12) gets a rebase conflict that’s obvious to
>     resolve, so I kept Vladimir’s R-b)
> 
> - As suggested by Vladimir, I added the root node name to the
>   cannot-follow-path error message in patch 14 (was: 16), and added an
>   assertion that the root node exists in the first place

Thanks, applied to the block branch.

Kevin