[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC qemu 3/6] mirror: add check for bitmap-mode without bitmap
From: |
Fabian Grünbichler |
Subject: |
[RFC qemu 3/6] mirror: add check for bitmap-mode without bitmap |
Date: |
Tue, 18 Feb 2020 11:07:37 +0100 |
as one without the other does not make much sense with the current set
of modes.
Signed-off-by: Fabian Grünbichler <address@hidden>
---
blockdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 8f7b7ba5eb..23df9f76ba 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3868,6 +3868,9 @@ static void blockdev_mirror_common(const char *job_id,
BlockDriverState *bs,
if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_ALLOW_RO, errp)) {
return;
}
+ } else if (has_bitmap_mode) {
+ error_setg(errp, "Cannot specify bitmap sync mode without a bitmap");
+ return;
}
if (has_replaces) {
--
2.20.1
- [RFC qemu 0/6] mirror: implement incremental and bitmap modes, Fabian Grünbichler, 2020/02/18
- [RFC qemu 4/6] mirror: switch to bdrv_dirty_bitmap_merge_internal, Fabian Grünbichler, 2020/02/18
- [RFC qemu 2/6] drive-mirror: add support for conditional and always bitmap sync modes, Fabian Grünbichler, 2020/02/18
- [RFC qemu 3/6] mirror: add check for bitmap-mode without bitmap,
Fabian Grünbichler <=
- [RFC qemu 6/6] mirror: move some checks to QMP, Fabian Grünbichler, 2020/02/18
- [RFC qemu 1/6] drive-mirror: add support for sync=bitmap mode=never, Fabian Grünbichler, 2020/02/18
- [RFC qemu 5/6] iotests: add test for bitmap mirror, Fabian Grünbichler, 2020/02/18
- Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes, no-reply, 2020/02/18
- Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes, John Snow, 2020/02/25