[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c |
Date: |
Mon, 20 Jan 2020 11:55:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
On 19.12.19 11:03, Vladimir Sementsov-Ogievskiy wrote:
> The function is definitely internal (it's not used by third party and
> it has complicated interface). Move it to .c file.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> include/qemu/hbitmap.h | 30 ------------------------------
> util/hbitmap.c | 29 +++++++++++++++++++++++++++++
> 2 files changed, 29 insertions(+), 30 deletions(-)
I wonder why you removed the “inline”, but then again we should probably
trust the compiler more than our intuition anyway.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v3 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c,
Max Reitz <=