[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/30] qcow2: Declare BDRV_REQ_NO_FALLBACK supported
From: |
Kevin Wolf |
Subject: |
[PULL 08/30] qcow2: Declare BDRV_REQ_NO_FALLBACK supported |
Date: |
Thu, 19 Dec 2019 18:24:19 +0100 |
In the common case, qcow2_co_pwrite_zeroes() already only modifies
metadata case, so we're fine with or without BDRV_REQ_NO_FALLBACK set.
The only exception is when using an external data file, where the
request is passed down to the block driver of the external data file. We
are forwarding the BDRV_REQ_NO_FALLBACK flag there, though, so this is
fine, too.
Declare the flag supported therefore.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/qcow2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 7c18721741..de0e89cf25 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1722,7 +1722,8 @@ static int coroutine_fn qcow2_do_open(BlockDriverState
*bs, QDict *options,
}
}
- bs->supported_zero_flags = header.version >= 3 ? BDRV_REQ_MAY_UNMAP : 0;
+ bs->supported_zero_flags = header.version >= 3 ?
+ BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK : 0;
/* Repair image if dirty */
if (!(flags & (BDRV_O_CHECK | BDRV_O_INACTIVE)) && !bs->read_only &&
--
2.20.1
- [PULL 00/30] Block layer patches, Kevin Wolf, 2019/12/19
- [PULL 02/30] iotests: Skip test 060 if it is not possible to create large files, Kevin Wolf, 2019/12/19
- [PULL 01/30] iotests: Provide a function for checking the creation of huge files, Kevin Wolf, 2019/12/19
- [PULL 03/30] iotests: Skip test 079 if it is not possible to create large files, Kevin Wolf, 2019/12/19
- [PULL 04/30] qapi: better document NVMe blockdev @device parameter, Kevin Wolf, 2019/12/19
- [PULL 06/30] block: Error out on image creation with conflicting size options, Kevin Wolf, 2019/12/19
- [PULL 05/30] qemu-img: fix info --backing-chain --image-opts, Kevin Wolf, 2019/12/19
- [PULL 08/30] qcow2: Declare BDRV_REQ_NO_FALLBACK supported,
Kevin Wolf <=
- [PULL 07/30] blockjob: Fix error message for negative speed, Kevin Wolf, 2019/12/19
- [PULL 09/30] iotests: Add qemu_io_log(), Kevin Wolf, 2019/12/19
- [PULL 10/30] iotests: Fix timeout in run_job(), Kevin Wolf, 2019/12/19
- [PULL 11/30] iotests: Support job-complete in run_job(), Kevin Wolf, 2019/12/19
- [PULL 12/30] qcow2: Use offset_into_cluster(), Kevin Wolf, 2019/12/19
- [PULL 14/30] iotests: Add more "_require_drivers" checks to the shell-based tests, Kevin Wolf, 2019/12/19
- [PULL 13/30] MAINTAINERS: fix qcow2-bitmap.c under Dirty Bitmaps header, Kevin Wolf, 2019/12/19
- [PULL 17/30] qcow2: Move error check of local_err near its assignment, Kevin Wolf, 2019/12/19
- [PULL 15/30] iotests/273: Filter format-specific information, Kevin Wolf, 2019/12/19
- [PULL 16/30] iotests: Fix IMGOPTSSYNTAX for nbd, Kevin Wolf, 2019/12/19