Re: [PATCH 3/3] block/io: take bs->reqs_lock in bdrv_mark_request_serialising

[Kevin Wolf]

Am 18.12.2019 um 14:17 hat Paolo Bonzini geschrieben:
> bdrv_mark_request_serialising is writing the overlap_offset and
> overlap_bytes fields of BdrvTrackedRequest.  Take bs->reqs_lock
> for the whole direction of it, and not just when waiting for

Is "direction" really the word you meant?

> serialising requests, so that tracked_request_overlaps does not
> look at a half-updated request.
> 
> The new code does not unlock/relock around retries.  This is unnecessary
> because a retry is always preceded by a CoQueue wait, which already
> releases and reacquired bs->reqs_lock.
> 
> Reported-by: Peter Lieven <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>