[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overl
From: |
Max Reitz |
Subject: |
Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays |
Date: |
Mon, 25 Nov 2019 13:21:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 22.11.19 17:41, Eric Blake wrote:
> On 11/22/19 10:17 AM, Peter Maydell wrote:
[...]
>> Eyeballing of the diffstat plus the fact we're on v4 of
>> the patchset already makes me a little uneasy about
>> putting it into rc3, but if the bug we're fixing matters
>> enough we can do it.
>
> In terms of diffstat, the v3 series was much smaller in impact. Both
> versions add robustness, where the difference between v3 and v4 is
> whether we introduce a speed penalty on an unlikely setup (v3) or reject
> any operation where it would require a speed penalty to avoid data
> problems (v4).
I’d just like to add that this isn’t just about a speed penalty, but
about the fact that the monitor is blocked while the operation is
running. So the speed penalty has more impact than just some background
operation being slow.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH v3 3/8] qcow2: Declare BDRV_REQ_NO_FALLBACK supported, (continued)
- [PATCH v3 5/8] iotests: Add qemu_io_log(), Kevin Wolf, 2019/11/22
- [PATCH v3 6/8] iotests: Fix timeout in run_job(), Kevin Wolf, 2019/11/22
- [PATCH v3 7/8] iotests: Support job-complete in run_job(), Kevin Wolf, 2019/11/22
- [PATCH v3 8/8] iotests: Test committing to short backing file, Kevin Wolf, 2019/11/22
- Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays, Peter Maydell, 2019/11/22
- Re: [PATCH for-4.2? v3 0/8] block: Fix resize (extending) of short overlays, Max Reitz, 2019/11/25