[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_ba
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup |
Date: |
Tue, 19 Nov 2019 10:14:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 12.11.19 12:30, Sergio Lopez wrote:
> Consolidate drive_backup_prepare() with do_drive_backup() as a first
> step towards streamlining all functionality through transactions.
>
> Signed-off-by: Sergio Lopez <address@hidden>
> ---
> blockdev.c | 58 +++++++++++++++---------------------------------------
> 1 file changed, 16 insertions(+), 42 deletions(-)
qemu no longer compiles with this patch applied, for two reasons:
(1) actions[TRANSACTION_ACTION_KIND_DRIVE_BACKUP].prepare is initialized
with drive_backup_prepare on line 2175, but this patch merges it into
do_drive_backup(), which is only on line 3556, so we need a forward
declaration.
(2) qmp_drive_backup() calls do_drive_backup(), but that function no
longer exists.
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup, Sergio Lopez, 2019/11/12
- [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup, Sergio Lopez, 2019/11/12
- Re: [PATCH v3 1/8] blockdev: merge drive_backup_prepare with do_drive_backup,
Max Reitz <=
- [PATCH v3 4/8] blockdev: change qmp_drive_backup to make use of transactions, Sergio Lopez, 2019/11/12
- [PATCH v3 2/8] blockdev: fix coding style issues in drive_backup_prepare, Sergio Lopez, 2019/11/12
- [PATCH v3 8/8] blockdev: honor bdrv_try_set_aio_context() context requirements, Sergio Lopez, 2019/11/12
- [PATCH v3 6/8] blockdev: place blockdev_backup_prepare with the other related transaction helpers, Sergio Lopez, 2019/11/12
- [PATCH v3 7/8] blockdev: change qmp_blockdev_backup to make use of transactions, Sergio Lopez, 2019/11/12
- [PATCH v3 5/8] blockdev: merge blockdev_backup_prepare with do_blockdev_backup, Sergio Lopez, 2019/11/12
- [PATCH v3 3/8] blockdev: place drive_backup_prepare with the other related transaction functions, Sergio Lopez, 2019/11/12
- Re: [PATCH v3 0/8] blockdev: avoid acquiring AioContext lock twice at do_drive_backup and do_blockdev_backup, no-reply, 2019/11/12