Re: [PATCH v2 0/2] block/nvme: add support for write zeros and discard

[Max Reitz]

On 13.09.19 15:36, Maxim Levitsky wrote:
> This is the second part of the patches I prepared
> for this driver back when I worked on mdev-nvme.
> 
> V2: addressed review feedback, no major changes
> 
> Best regards,
>       Maxim Levitsky
> 
> Maxim Levitsky (2):
>   block/nvme: add support for write zeros
>   block/nvme: add support for discard
> 
>  block/nvme.c         | 155 ++++++++++++++++++++++++++++++++++++++++++-
>  block/trace-events   |   3 +
>  include/block/nvme.h |  19 +++++-
>  3 files changed, 175 insertions(+), 2 deletions(-)
Thanks, fixed the indentation in nvme.h in patch 1, and applied to my
block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

For the record, I don’t think !!x has benefits over x != 0 and I
personally prefer bool y = x over any of it. O:-)

Max

signature.asc
Description: OpenPGP digital signature