Re: [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step

[Thomas Huth]

----- Original Message -----
> From: "Stefan Hajnoczi" <address@hidden>
> Sent: Wednesday, October 23, 2019 12:04:17 PM
> 
> Device initialization has an extra step in VIRTIO 1.0.  The FEATURES_OK
> status bit is set to indicate that feature negotiation has completed.
> The driver then reads the status register again to check that the device
> agrees with the final features.
> 
> Implement this step as part of qvirtio_set_features() instead of
> introducing a separate function.  This way all existing code works
> without modifications.
> 
> The check in qvirtio_set_driver_ok() needs to be updated because
> FEATURES_OK will be set for VIRTIO 1.0 devices.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> v4:
>  * Make FEATURES_OK change in qvirtio_set_driver_ok() clearer and
>    mention it in the commit description [Thomas]
> ---
>  tests/libqos/virtio.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

Reviewed-by: Thomas Huth" <address@hidden>