|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PULL 1/2] trace: add --group=all to tracing.txt |
Date: | Mon, 14 Oct 2019 11:08:25 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
Hi Stefan, On 10/14/19 10:57 AM, Stefan Hajnoczi wrote:
tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation. Fixes: 2098c56a9bc5901e145fa5d4759f075808811685 ("trace: move setting of group name into Makefiles") Launchpad: https://bugs.launchpad.net/bugs/1844814
Sorry I didn't noticed that earlier, but on https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message we recommend using the 'Buglink' tag.
Not sure it's worth resending another pull request...
Reported-by: Philippe Mathieu-Daudé <address@hidden> Reviewed-by: Daniel P. Berrangé <address@hidden> Reviewed-by: Philippe Mathieu-Daudé <address@hidden> Tested-by: Philippe Mathieu-Daudé <address@hidden> Signed-off-by: Stefan Hajnoczi <address@hidden> Message-Id: <address@hidden> --- docs/devel/tracing.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt index 8231bbf5d1..8c0376fefa 100644 --- a/docs/devel/tracing.txt +++ b/docs/devel/tracing.txt @@ -317,7 +317,8 @@ probes: --binary path/to/qemu-binary \ --target-type system \ --target-name x86_64 \ - <trace-events-all >qemu.stp + --group=all \ + trace-events-all >qemu.stpTo facilitate simple usage of systemtap where there merely needs to be printflogging of certain probes, a helper script "qemu-trace-stap" is provided.
[Prev in Thread] | Current Thread | [Next in Thread] |