[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/67] iotests.py: Read $IMGOPTS
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH 01/67] iotests.py: Read $IMGOPTS |
Date: |
Thu, 3 Oct 2019 15:08:37 +0000 |
01.10.2019 22:46, Max Reitz wrote:
> We do not do anything with yet, but this is the first step.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 1c5fce3e9e..7030900807 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -69,6 +69,12 @@ output_dir = os.environ.get('OUTPUT_DIR', '.')
> cachemode = os.environ.get('CACHEMODE')
> qemu_default_machine = os.environ.get('QEMU_DEFAULT_MACHINE')
>
> +imgopts = os.environ.get('IMGOPTS', '')
> +if len(imgopts) == 0:
> + imgopts = []
> +else:
> + imgopts = imgopts.split(',')
> +
> socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
>
> luks_default_secret_object = 'secret,id=keysec0,data=' + \
>
Note, that empty sequences are always false, so you may use just "if not
imgopts"
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
--
Best regards,
Vladimir