[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v15 2/5] block/backup: move write_flags calculation inside backup
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v15 2/5] block/backup: move write_flags calculation inside backup_job_create |
Date: |
Tue, 1 Oct 2019 16:14:06 +0300 |
This is logic-less refactoring, which simplifies further patch, as
we'll need write_flags for backup-top filter creation and backup-top
should be created before block job creation.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/backup.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index d918836f1d..b5b7939356 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -446,20 +446,6 @@ BlockJob *backup_job_create(const char *job_id,
BlockDriverState *bs,
goto error;
}
- /* job->len is fixed, so we can't allow resize */
- job = block_job_create(job_id, &backup_job_driver, txn, bs, 0,
BLK_PERM_ALL,
- speed, creation_flags, cb, opaque, errp);
- if (!job) {
- goto error;
- }
-
- job->source_bs = bs;
- job->on_source_error = on_source_error;
- job->on_target_error = on_target_error;
- job->sync_mode = sync_mode;
- job->sync_bitmap = sync_bitmap;
- job->bitmap_mode = bitmap_mode;
-
/*
* If source is in backing chain of target assume that target is going to
be
* used for "image fleecing", i.e. it should represent a kind of snapshot
of
@@ -477,6 +463,20 @@ BlockJob *backup_job_create(const char *job_id,
BlockDriverState *bs,
write_flags = (bdrv_chain_contains(target, bs) ? BDRV_REQ_SERIALISING : 0)
|
(compress ? BDRV_REQ_WRITE_COMPRESSED : 0),
+ /* job->len is fixed, so we can't allow resize */
+ job = block_job_create(job_id, &backup_job_driver, txn, bs, 0,
BLK_PERM_ALL,
+ speed, creation_flags, cb, opaque, errp);
+ if (!job) {
+ goto error;
+ }
+
+ job->source_bs = bs;
+ job->on_source_error = on_source_error;
+ job->on_target_error = on_target_error;
+ job->sync_mode = sync_mode;
+ job->sync_bitmap = sync_bitmap;
+ job->bitmap_mode = bitmap_mode;
+
job->bcs = block_copy_state_new(bs, target, cluster_size, write_flags,
backup_progress_bytes_callback,
backup_progress_reset_callback, job, errp);
@@ -485,11 +485,11 @@ BlockJob *backup_job_create(const char *job_id,
BlockDriverState *bs,
}
job->cluster_size = cluster_size;
+ job->len = len;
/* Required permissions are already taken by block-copy-state target */
block_job_add_bdrv(&job->common, "target", target, 0, BLK_PERM_ALL,
&error_abort);
- job->len = len;
return &job->common;
--
2.21.0
- [PATCH v15 0/5] backup-top filter driver for backup, Vladimir Sementsov-Ogievskiy, 2019/10/01
- [PATCH v15 2/5] block/backup: move write_flags calculation inside backup_job_create,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v15 1/5] block/backup: move in-flight requests handling from backup to block-copy, Vladimir Sementsov-Ogievskiy, 2019/10/01
- [PATCH v15 3/5] block/block-copy: split block_copy_set_callbacks function, Vladimir Sementsov-Ogievskiy, 2019/10/01
- [PATCH v15 4/5] block: introduce backup-top filter driver, Vladimir Sementsov-Ogievskiy, 2019/10/01
- [PATCH v15 5/5] block/backup: use backup-top instead of write notifiers, Vladimir Sementsov-Ogievskiy, 2019/10/01
- Re: [PATCH v15 0/5] backup-top filter driver for backup, Max Reitz, 2019/10/04