[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/18] iotests: Drop compat=1.1 in 050
|
From: |
Maxim Levitsky |
|
Subject: |
Re: [PATCH 03/18] iotests: Drop compat=1.1 in 050 |
|
Date: |
Sun, 29 Sep 2019 19:32:09 +0300 |
On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote:
> IMGOPTS can never be empty for qcow2, because the check scripts adds
> compat=1.1 unless the user specified any compat option themselves.
> Thus, this block does not do anything and can be dropped.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/050 | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/qemu-iotests/050 b/tests/qemu-iotests/050
> index 211fc00797..272ecab195 100755
> --- a/tests/qemu-iotests/050
> +++ b/tests/qemu-iotests/050
> @@ -41,10 +41,6 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _supported_fmt qcow2 qed
> _supported_proto file
>
> -if test "$IMGFMT" = qcow2 && test $IMGOPTS = ""; then
> - IMGOPTS=compat=1.1
> -fi
> -
> echo
> echo "== Creating images =="
>
Reviewed-by: Maxim Levitsky <address@hidden>
Best regards,
Maxim Levitsky
- [PATCH 00/18] iotests: Allow ./check -o data_file, Max Reitz, 2019/09/27
- [PATCH 01/18] iotests: Filter refcount_order in 036, Max Reitz, 2019/09/27
- [PATCH 02/18] iotests: Replace IMGOPTS by _unsupported_imgopts, Max Reitz, 2019/09/27
- [PATCH 03/18] iotests: Drop compat=1.1 in 050, Max Reitz, 2019/09/27
- Re: [PATCH 03/18] iotests: Drop compat=1.1 in 050,
Maxim Levitsky <=
- [PATCH 04/18] iotests: Let _make_test_img parse its parameters, Max Reitz, 2019/09/27
- [PATCH 05/18] iotests: Add -o and --no-opts to _make_test_img, Max Reitz, 2019/09/27
- [PATCH 06/18] iotests: Inject space into -ocompat=0.10 in 051, Max Reitz, 2019/09/27
- [PATCH 08/18] iotests: Replace IMGOPTS='' by --no-opts, Max Reitz, 2019/09/27
- [PATCH 07/18] iotests: Replace IMGOPTS= by -o, Max Reitz, 2019/09/27