Re: [PATCH v3 0/3] proper locking on bitmap add/remove paths

[John Snow]

On 9/20/19 4:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> We need to lock qcow2 mutex on accessing in-image metadata, especially
> on updating this metadata. Let's implement it.
> 
> v3:
> 01: add John's r-b
> 02: - fix bdrv_remove_persistent_dirty_bitmap return value
>     - drop extra zeroing of ret in qcow2_remove_persistent_dirty_bitmap
> 03: add John's r-b
> 
> Vladimir Sementsov-Ogievskiy (3):
>   block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c
>   block/dirty-bitmap: return int from
>     bdrv_remove_persistent_dirty_bitmap
>   block/qcow2: proper locking on bitmap add/remove paths
> 
>  block/qcow2.h                |  14 ++---
>  include/block/block_int.h    |  14 ++---
>  include/block/dirty-bitmap.h |   5 +-
>  block.c                      |  22 -------
>  block/dirty-bitmap.c         | 119 +++++++++++++++++++++++++++++++++--
>  block/qcow2-bitmap.c         |  36 +++++++----
>  block/qcow2.c                |   5 +-
>  blockdev.c                   |  28 +++------
>  8 files changed, 163 insertions(+), 80 deletions(-)
> 

Thanks, applied to my bitmaps tree:

https://github.com/jnsnow/qemu/commits/bitmaps
https://github.com/jnsnow/qemu.git

--js