[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/22] quorum: Fix child permissions
From: |
Max Reitz |
Subject: |
Re: [PATCH 05/22] quorum: Fix child permissions |
Date: |
Thu, 26 Sep 2019 13:02:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 25.09.19 13:56, Vladimir Sementsov-Ogievskiy wrote:
> 20.09.2019 18:27, Max Reitz wrote:
>> Quorum is not actually a filter. It cannot share WRITE or RESIZE on its
>> children.
>
> Hmm, backup-top don't want to share WRITE or RESIZE too, but it's a filter
> still..
> May it be just "Quorum cannot share WRITE or RESIZE on its children." ?
I suppose the original reason for sharing it was just “It’s a filter, so
let’s make it use bdrv_filter_default_perms().” So that’s what I was
trying to hint at. I’ll try to be a bit more verbose. Or less,
depending on what I find looks better. :-)
Max
>> Signed-off-by: Max Reitz <address@hidden>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
>
>
signature.asc
Description: OpenPGP digital signature
- [PATCH 01/22] blockdev: Allow external snapshots everywhere, (continued)
- [PATCH 01/22] blockdev: Allow external snapshots everywhere, Max Reitz, 2019/09/20
- [PATCH 03/22] block: Drop bdrv_is_first_non_filter(), Max Reitz, 2019/09/20
- [PATCH 02/22] blockdev: Allow resizing everywhere, Max Reitz, 2019/09/20
- [PATCH 04/22] iotests: Let 041 use -blockdev for quorum children, Max Reitz, 2019/09/20
- [PATCH 05/22] quorum: Fix child permissions, Max Reitz, 2019/09/20
- [PATCH 06/22] block: Add bdrv_recurse_can_replace(), Max Reitz, 2019/09/20
- [PATCH 09/22] quorum: Add QuorumChild.to_be_replaced, Max Reitz, 2019/09/20
- [PATCH 08/22] quorum: Store children in own structure, Max Reitz, 2019/09/20
- [PATCH 07/22] blkverify: Implement .bdrv_recurse_can_replace(), Max Reitz, 2019/09/20