[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the exp

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v2] nbd/server: attach client channel to the export's AioContext
Date: Fri, 20 Sep 2019 17:03:31 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 9/20/19 2:11 PM, Eric Blake wrote:
> On 9/20/19 1:49 PM, John Snow wrote:
>>>> To fix this, as soon we have the export corresponding to the client,
>>>> we call qio_channel_attach_aio_context() to attach the QIOChannel
>>>> context to the export's AioContext. This matches with the logic at
>>>> blk_aio_attached().
>>> I assume this patch has been superseded by Eric's later patches?
>> Nevermind -- my filtering got messed up slightly and I missed the
>> followup. I see that Eric staged this.
> I actually think both patches are needed: this one covers transactions,
> while my later patch was on top of this to protect shutdown.  But now
> you've made me curious; I'll see if my patch hoisted in front still
> solves everything, or if we really do need both.

Nope, both patches are still needed.  Sergio's fixes the assertion:
    (qemu) qemu-kvm: io/channel.c:411: qio_channel_restart_read:
Assertion `qemu_get_current_aio_context() ==
qemu_coroutine_get_aio_context(co)' failed.

while mine fixes:
+qemu: qemu_mutex_unlock_impl: Operation not permitted

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]