[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v4 3/7] iotests: Use case_skip() in

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v4 3/7] iotests: Use case_skip() in skip_if_unsupported()
Date: Wed, 18 Sep 2019 14:31:19 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 9/17/19 5:20 AM, Max Reitz wrote:
skip_if_unsupported() should use the stronger variant case_skip(),
because this allows it to be used even with setUp() (in a meaningful

In the process, make it explicit what we expect the first argument of
the func_wrapper to be (namely something derived of QMPTestCase).

Signed-off-by: Max Reitz <address@hidden>
  tests/qemu-iotests/iotests.py | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index e46f3b6aed..427c34697a 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -893,14 +893,14 @@ def skip_if_unsupported(required_formats=[], 
      '''Skip Test Decorator
         Runs the test if all the required formats are whitelisted'''
      def skip_test_decorator(func):
-        def func_wrapper(*args, **kwargs):
+        def func_wrapper(test_case: QMPTestCase, *args, **kwargs):

The dream lives!

              usf_list = list(set(required_formats) -
              if usf_list:
-                case_notrun('{}: formats {} are not whitelisted'.format(
-                    args[0], usf_list))
+                test_case.case_skip('{}: formats {} are not 
+                    test_case, usf_list))
-                return func(*args, **kwargs)
+                return func(test_case, *args, **kwargs)
          return func_wrapper
      return skip_test_decorator

Reviewed-by: John Snow <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]