[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 10/17] s390x/css: Pass local error object pointe

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint()
Date: Wed, 18 Sep 2019 12:46:42 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 9/18/19 5:26 AM, Cornelia Huck wrote:
> On Tue, 17 Sep 2019 18:36:20 +0200
> Greg Kurz <address@hidden> wrote:
>> On Tue, 17 Sep 2019 13:24:12 +0200
>> Cornelia Huck <address@hidden> wrote:
>>> On Tue, 17 Sep 2019 12:21:34 +0200
>>> Greg Kurz <address@hidden> wrote:
>>>> Ensure that hints are added even if errp is &error_fatal or &error_abort.
>>>> Signed-off-by: Greg Kurz <address@hidden>
>>>> ---
>>>>  hw/s390x/s390-ccw.c |    6 ++++--
>>>>  1 file changed, 4 insertions(+), 2 deletions(-)  
>>> Reviewed-by: Cornelia Huck <address@hidden>
>>> Can also take this via the s390 tree, let me know what would work best.  
>> I guess it would be easier to merge if each individual patch goes
>> through the corresponding sub-maintainer tree. But Eric mentioned
>> in another mail that the whole whole series could maybe go through
>> Markus' error tree... so, I don't know which is best. :)
> Ok, it's probably best to take this through the s390 tree, as I plan to
> send a pull request tomorrow :)

If we go with Vladimir's idea of auto-propagation, this change just gets
rewritten again as part of our simplifications to drop all use of
'local_err' in favor of instead using the macro that makes errp always
safe to use locally.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]