[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/17] error: Update error_append_hint()'s docum
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-block] [PATCH 01/17] error: Update error_append_hint()'s documentation |
|
Date: |
Tue, 17 Sep 2019 13:21:02 +0200 |
On Tue, 17 Sep 2019 12:20:37 +0200
Greg Kurz <address@hidden> wrote:
> error_setg() and error_propagate(), as well as their variants, cause
> QEMU to terminate when called with &error_fatal or &error_abort. This
> prevents to add hints since error_append_hint() isn't even called in
> this case.
>
> It means that error_append_hint() should only be used with a local
> error object, and then propagate this local error to the caller.
>
> Document this in <qapi/error.h> .
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> include/qapi/error.h | 11 ++++++++++-
It's a bit awkward requiring a local object, but better safe than sorry.
Reviewed-by: Cornelia Huck <address@hidden>
- Re: [Qemu-block] [PATCH 01/17] error: Update error_append_hint()'s documentation,
Cornelia Huck <=