Re: [Qemu-block] [PATCH v2 1/2] trace: Remove trailing newline in events

[Philippe Mathieu-Daudé]

On 9/16/19 6:36 PM, Eric Blake wrote:
> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote:
>> While the tracing frawework does not forbid trailing newline in
> 
> framework
> 
>> events format string, using them lead to confuse output.
>> It is the responsibility of the backend to properly end an event
>> line.
> 
> Why just trailing newline? Should we not forbid ALL use of newline in a
> trace message?

I thought about it and forgot to add a comment when respining.
Yes, I think this is the right thing to enforce.
However it requires more cleanup, affecting more subsystems, so I'd
rather keep it for a follow-up series.

>>
>> Some of our formats have trailing newlines, remove them.
>>
>> Reviewed-by: John Snow <address@hidden>
>> Reviewed-by: Kevin Wolf <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---