[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v4 0/3] Fix qcow2+luks corruption introduced by comm
From: |
Maxim Levitsky |
Subject: |
[Qemu-block] [PATCH v4 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335 |
Date: |
Fri, 13 Sep 2019 15:59:06 +0300 |
Commit 8ac0f15f335 accidently broke the COW of non changed areas
of newly allocated clusters, when the write spans multiple clusters,
and needs COW both prior and after the write.
This results in 'after' COW area being encrypted with wrong
sector address, which render it corrupted.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922
CC: qemu-stable <address@hidden>
V2: grammar, spelling and code style fixes.
V3: more fixes after the review.
V4: addressed review comments from Max Reitz,
and futher refactored the qcow2_co_encrypt to just take full host and guest
offset
which simplifies everything.
Best regards,
Maxim Levitsky
Maxim Levitsky (3):
block/qcow2: refactoring of threaded encryption code
block/qcow2: fix the corruption when rebasing luks encrypted files
qemu-iotests: Add test for bz #1745922
block/qcow2-cluster.c | 29 +++++++-----
block/qcow2-threads.c | 62 ++++++++++++++++++++------
block/qcow2.c | 5 ++-
block/qcow2.h | 8 ++--
tests/qemu-iotests/263 | 91 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/263.out | 40 +++++++++++++++++
tests/qemu-iotests/group | 1 +
7 files changed, 205 insertions(+), 31 deletions(-)
create mode 100755 tests/qemu-iotests/263
create mode 100644 tests/qemu-iotests/263.out
--
2.17.2
- [Qemu-block] [PATCH v4 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335,
Maxim Levitsky <=
- [Qemu-block] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Maxim Levitsky, 2019/09/13
- Re: [Qemu-block] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Vladimir Sementsov-Ogievskiy, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Maxim Levitsky, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Vladimir Sementsov-Ogievskiy, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Kevin Wolf, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Maxim Levitsky, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Vladimir Sementsov-Ogievskiy, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Kevin Wolf, 2019/09/13
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code, Kevin Wolf, 2019/09/13
[Qemu-block] [PATCH v4 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files, Maxim Levitsky, 2019/09/13