[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 17/22] iotests: Valgrind fails with nonexistent direc
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 17/22] iotests: Valgrind fails with nonexistent directory |
Date: |
Thu, 12 Sep 2019 15:45:59 +0200 |
From: Andrey Shinkevich <address@hidden>
The Valgrind uses the exported variable TMPDIR and fails if the
directory does not exist. Let us exclude such a test case from
being run under the Valgrind and notify the user of it.
Suggested-by: Kevin Wolf <address@hidden>
Signed-off-by: Andrey Shinkevich <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
tests/qemu-iotests/051 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index ce942a5444..53bcdbc911 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -377,6 +377,10 @@ printf %b "qemu-io $device_id \"write -P 0x33 0
4k\"\ncommit $device_id\n" |
$QEMU_IO -c "read -P 0x33 0 4k" "$TEST_IMG" | _filter_qemu_io
# Using snapshot=on with a non-existent TMPDIR
+if [ "${VALGRIND_QEMU_VM}" == "y" ]; then
+ _casenotrun "Valgrind needs a valid TMPDIR for itself"
+fi
+VALGRIND_QEMU_VM= \
TMPDIR=/nonexistent run_qemu -drive driver=null-co,snapshot=on
# Using snapshot=on together with read-only=on
--
2.20.1
- [Qemu-block] [PULL 06/22] file-posix: Fix has_write_zeroes after NO_FALLBACK, (continued)
- [Qemu-block] [PULL 06/22] file-posix: Fix has_write_zeroes after NO_FALLBACK, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 08/22] iotests: Add supported protocols to execute_test(), Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 10/22] iotests: Restrict nbd Python tests to nbd, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 09/22] iotests: Restrict file Python tests to file, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 11/22] iotests: Test blockdev-create for vpc, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 12/22] iotests: skip 232 when run tests as root, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 13/22] block/nfs: add support for nfs_umount, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 15/22] iotests: exclude killed processes from running under Valgrind, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 16/22] iotests: Add casenotrun report to bash tests, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 14/22] iotests: allow Valgrind checking all QEMU processes, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 17/22] iotests: Valgrind fails with nonexistent directory,
Kevin Wolf <=
- [Qemu-block] [PULL 18/22] iotests: extended timeout under Valgrind, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 19/22] iotests: extend sleeping time under Valgrind, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 20/22] qemu-io: Don't leak pattern file in error path, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 22/22] qcow2: Stop overwriting compressed clusters one by one, Kevin Wolf, 2019/09/12
- [Qemu-block] [PULL 21/22] block/create: Do not abort if a block driver is not available, Kevin Wolf, 2019/09/12
- Re: [Qemu-block] [PULL 00/22] Block layer patches, Peter Maydell, 2019/09/13