Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] proper locking on bitmap add/remove paths

[Vladimir Sementsov-Ogievskiy]

12.09.2019 0:46, John Snow wrote:
> 
> 
> On 9/11/19 10:09 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 10.09.2019 23:37, address@hidden wrote:
>>> Patchew URL: https://patchew.org/QEMU/address@hidden/
>>>
>>>
>>>
>>> Hi,
>>>
>>> This series failed the docker-quick@centos7 build test. Please find the 
>>> testing commands and
>>> their output below. If you have Docker installed, you can probably 
>>> reproduce it
>>> locally.
>>>
>>> === TEST SCRIPT BEGIN ===
>>> #!/bin/bash
>>> make docker-image-centos7 V=1 NETWORK=1
>>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> 
> (Was patchew even using clang?)

hmm gcc 9.2 don't show such error but clang does.

> 
>>> === TEST SCRIPT END ===
>>>
>>> libudev           no
>>> default devices   yes
>>>
>>> warning: Python 2 support is deprecated
>>> warning: Python 3 will be required for building future versions of QEMU
>>>
>>> NOTE: cross-compilers enabled:  'cc'
>>>     GEN     x86_64-softmmu/config-devices.mak.tmp
>>> ---
>>>     CC      block/qed-cluster.o
>>>     CC      block/qed-check.o
>>> /tmp/qemu-test/src/block/qcow2-bitmap.c: In function 
>>> 'qcow2_co_remove_persistent_dirty_bitmap':
>>> /tmp/qemu-test/src/block/qcow2-bitmap.c:502:8: error: 'bm' may be used 
>>> uninitialized in this function [-Werror=maybe-uninitialized]
>>>        if (bm == NULL) {
>>>           ^
>>> /tmp/qemu-test/src/block/qcow2-bitmap.c:1413:18: note: 'bm' was declared 
>>> here
>>>
>>>
>>> The full log is available at
>>> http://patchew.org/logs/address@hidden/testing.docker-quick@centos7/?type=message.
>>> ---
>>> Email generated automatically by Patchew [https://patchew.org/].
>>> Please send your feedback to address@hidden
>>>
>>
>> Who knows, how to clang Qemu?
>>
>> I try with
>> ./configure --target-list=x86_64-softmmu --enable-debug --disable-virtfs 
>> --enable-werror --audio-drv-list=oss --extra-cflags=-Wall 
>> --enable-sanitizers --cc=clang --cxx=clang++
>> make -j9
>>
> 
> ../../configure --target-list="x86_64-softmmu" --cc=clang --cxx=clang++
> --host-cc=clang
> 
> works OK for me in fedora 30.

So, now I've moved to fedora from rhel-based virtuozzo, and it just works :)

> 
> --target-list="x86_64-softmmu" --cc=clang --cxx=clang++ --host-cc=clang
> --enable-werror --extra-cflags=-Wall
> 
> Seems OK too, and finally adding
> 
> --enable-sanitizers
> 
> also appears to work alright.
> 
> 
> clang version 8.0.0 (Fedora 8.0.0-1.fc30)
> Target: x86_64-unknown-linux-gnu
> Thread model: posix
> InstalledDir: /usr/bin
> 
> 
> Maybe something bad in your ccache or some intermediate state in your
> build dir. I use separate build directories for gcc and clang just in case.
> 

Thanks for help!


-- 
Best regards,
Vladimir