[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/3] iotests: add script_initialize
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v2 1/3] iotests: add script_initialize |
|
Date: |
Tue, 10 Sep 2019 10:41:10 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 09.09.19 20:25, John Snow wrote:
>
>
> On 9/9/19 6:06 AM, Max Reitz wrote:
>> On 29.07.19 23:35, John Snow wrote:
>>> Like script_main, but doesn't require a single point of entry.
>>> Replace all existing initialization sections with this drop-in replacement.
>>>
>>> This brings debug support to all existing script-style iotests.
>>>
>>> Note: supported_oses=['linux'] was omitted, as it is a default argument.
>>> Signed-off-by: John Snow <address@hidden>
>>> ---
>>
>> Looks good to me, but I’m afraid I looked at this series too late (that
>> is, now), so I sent my own version of your 2/3, sorry. :-/
>>
>
> You're replying to v2; there was a v3.
Yes, I noticed later, sorry. Still, my (vpc) series is in Kevin’s
branch already, so I then thought to myself “Well, the comment about
some rebasing still applies, in a sense”.
Max
> I'll rebase V3 and re-send, especially if your version of 2/3 already
> hit master.
signature.asc
Description: OpenPGP digital signature