[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nvme: add support for di
Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard
Mon, 9 Sep 2019 13:03:47 -0400
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 9/9/19 5:25 AM, Max Reitz wrote:
> On 05.09.19 19:27, John Snow wrote:
>> You also probably require review (or at least an ACK) from Keith Busch
>> who maintains this file.
> Keith actually maintains the NVMe guest device; technically, Fam is the
> NVMe block driver maintainer.
W h o o p s. Thanks for correcting me.
Well, if it's Fam -- he seems a little busier lately -- it's probably
not so crucial to gate on his approval. I thought it'd be nice to at
least get an ACK from someone who has used this module before, because I
haven't -- I was just giving some style review to help push it along.
(On that note, if you felt like my style review was wrong or isn't worth
doing -- it is always perfectly fair to just say so, along with some
reason as to why you won't -- that way patches won't rot on the list
when people may have gotten the impression that a V2 is warranted.)