[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM f

From: Peter Maydell
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v9 8/9] hw/m68k: add a dummy SWIM floppy controller
Date: Mon, 9 Sep 2019 17:11:53 +0100

On Mon, 9 Sep 2019 at 17:05, Laurent Vivier <address@hidden> wrote:
> Co-developed-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> Reviewed-by: Hervé Poussineau <address@hidden>

> +static void sysbus_swim_class_init(ObjectClass *oc, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(oc);
> +
> +    dc->realize = sysbus_swim_realize;
> +}

Missing reset and VMState for migration. These should be
baseline requirements for adding new device models to the
tree, because in an ideal world every device would support
both -- we should be gradually fixing the existing devices
which are missing these, and not letting new devices in,
so the situation gets gradually better, not worse.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]