[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v6 09/42] block: Include filters when freezing b

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v6 09/42] block: Include filters when freezing backing chain
Date: Thu, 5 Sep 2019 15:05:01 +0200
User-agent: Mutt/1.12.0 (2019-05-25)

Am 09.08.2019 um 18:13 hat Max Reitz geschrieben:
> In order to make filters work in backing chains, the associated
> functions must be able to deal with them and freeze all filter links, be
> they COW or R/W filter links.
> In the process, rename these functions to reflect that they now act on
> generalized chains of filter nodes instead of backing chains alone.

I don't think this is a good idea. The functions are still following the
backing chain. A generic "chain" could mean following the bs->file links
or any other children, so the new name is confusing because it doesn't
really tell you any more what the function does. I'd prefer the name to
stay specific.

> While at it, add some comments that note which functions require their
> caller to ensure that a given child link is not frozen, and how the
> callers do so.
> Signed-off-by: Max Reitz <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]