[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/2] block/file-posix: Reduce xfsctl() use

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH 0/2] block/file-posix: Reduce xfsctl() use
Date: Mon, 2 Sep 2019 15:17:01 +0200
User-agent: Mutt/1.11.3 (2019-02-01)

Am 23.08.2019 um 15:03 hat Max Reitz geschrieben:
> Hi,
> As suggested by Paolo, this series drops xfsctl() calls where we have
> working fallocate() alternatives.  (And thus replaces “block/file-posix:
> Fix xfs_write_zeroes()”.)
> Unfortunately, we also use xfsctl() to inquire the request alignment for
> O_DIRECT, and this is the only way we currently have to obtain it
> without trying.  Therefore, I didn’t quite like removing that call, too,
> so this series doesn’t get rid of xfsctl() completely.
> (If we did, we could delete 146 lines instead of these measly 76 here.)
> Anyway, dropping xfs_write_zeroes() will also fix the guest corruptions
> Lukáš has reported (for qcow2, but I think it should be possible to see
> similar corruptions with raw, although I haven’t investigated that too
> far).

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]